-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename NotificationBanner component #979
Conversation
🦋 Changeset detectedLatest commit: 55993ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/HwPqUDRH4Dcgyds9RSF1FYgmWoAN |
Hey @robinmetral, Thanks! |
Codecov Report
@@ Coverage Diff @@
## next #979 +/- ##
==========================================
+ Coverage 91.66% 91.68% +0.01%
==========================================
Files 164 165 +1
Lines 3061 3077 +16
Branches 781 782 +1
==========================================
+ Hits 2806 2821 +15
- Misses 226 227 +1
Partials 29 29
|
.changeset/eleven-parrots-hope.md
Outdated
'@sumup/circuit-ui': major | ||
--- | ||
|
||
Rename NotificationBanner component into NotificationCard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd mention that we plan to deprecate it in the future (similar to what you wrote in the PR description).
Rename NotificationBanner component into NotificationCard. | |
Renamed the NotificationBanner component to NotificationCard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 55993ac
Purpose
This frees up the
NotificationBanner
namespace forv3.x
. We will later deprecate theNotification
,NotificationList
andNotificationCard
components in favor of the upcomingNotificationToast
,NotificationBanner
,NotificationFullscreen
andNotificationModal
components.Approach and changes
NotificationBanner
intoNotificationCard
Definition of done