Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the borderRadius update codemod #982

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

robinmetral
Copy link
Contributor

Purpose

The codemod will now transform two styled component patterns that are common in our apps, after the borderRadius update from #980:

  • ${theme.borderRadius.mega}
  • ${(p) => p.theme.borderRadius.mega}.

Approach and changes

  • Extend the codemod
  • We decided not to. support further, less common patterns like ${(props) => props.theme.borderRadius.mega}. Any occurrences of these will be manually migrated.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

The codemod now transforms both `${theme.borderRadius.mega}` and `${(p) => p.theme.borderRadius.mega}`.
@vercel
Copy link

vercel bot commented Jun 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/FoU7JmmnfXoueZUy23p5cDHYKUaR
✅ Preview: https://oss-circuit-ui-git-extend-theme-border-radius-codemod-sumup.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2021

⚠️ No Changeset found

Latest commit: ec056cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sumup-clark
Copy link

sumup-clark bot commented Jun 18, 2021

Hey @robinmetral,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #982 (ec056cc) into next (9548803) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #982      +/-   ##
==========================================
- Coverage   91.67%   91.66%   -0.02%     
==========================================
  Files         165      165              
  Lines        3063     3059       -4     
  Branches      754      754              
==========================================
- Hits         2808     2804       -4     
  Misses        227      227              
  Partials       28       28              
Impacted Files Coverage Δ
...ages/circuit-ui/cli/migrate/theme-border-radius.ts 100.00% <100.00%> (ø)

@robinmetral robinmetral merged commit 30d15b7 into next Jun 18, 2021
@robinmetral robinmetral deleted the extend-theme-border-radius-codemod branch June 18, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants