-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the typography-sizes changeset to transform Anchors #998
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/6pHmgK7YUsa9aLmPqYvgpi48FF4R |
Hey @robinmetral, Thanks! |
Codecov Report
@@ Coverage Diff @@
## next #998 +/- ##
==========================================
+ Coverage 90.96% 90.99% +0.02%
==========================================
Files 160 160
Lines 2646 2665 +19
Branches 763 765 +2
==========================================
+ Hits 2407 2425 +18
- Misses 214 215 +1
Partials 25 25
|
packages/circuit-ui/cli/migrate/__testfixtures__/typography-sizes.output.js
Show resolved
Hide resolved
🦋 Changeset detectedLatest commit: 4a03c40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟
Purpose
We overlooked the
Anchor
in the typography-sizes codemod for V3: it should be migrated just likeBody
, because it extends its props.Approach and changes
zetta
sizes and bodygiga
sizes that a manual migration is necessaryDefinition of done