support twikoo comment system #239

OnlyFor · 2021-07-14T01:50:34Z

No description provided.

release: 0.1.2

…yasin docs: add aiyasin as a contributor

RE #173 Use the selector already included with PR #173

fix(gist): fixed the lost of indentation

…latanado docs: add aplatanado as a contributor for code

…w717 docs: add ktw717 as a contributor for code, doc

victor-pogor

Hi @OnlyFor.

Thank you very much for your contributions. I left some comments on this PR.

Also, other things we will need to update:

Update the README.md file and add the required information in the features of these new comment systems.
Update the Theme Documentation basics article, on the configuration section, about these newly added comment systems.

victor-pogor · 2021-07-14T17:58:04Z

exampleSite/config.toml

+      [params.page.comment.waline]
+        enable = false
+        #js = "https://cdn.jsdelivr.net/npm/@waline/client@latest"
+        js = "https://cdn.jsdelivr.net/npm/@waline/client/dist/Waline.min.js"


Can you move please this parameter in the assets/data/cdn/jsdelivr.yml file?

We have a single place for the CDN files.

victor-pogor · 2021-07-14T18:00:04Z

exampleSite/config.toml

+		dark = 'auto'
+      [params.page.comment.twikoo]
+        enable = false
+		js = "https://cdn.jsdelivr.net/npm/[email protected]/dist/twikoo.all.min.js"


I think the properties should be indented at the same level, they're all referenced to the params.page.comment.twikoo group.

victor-pogor · 2021-07-14T18:05:49Z

layouts/partials/comment.html

+        {{- $twikoo := $comment.twikoo | default dict -}}
+        {{- if $twikoo.enable -}}
+			<div id="twikoo"></div>
+			<script src="{{ $twikoo.js }}"></script>


Can you use something like this?

CodeIT/layouts/partials/comment.html

Lines 19 to 31 in a74cdcf

{{- /* Gitalk Comment System */ -}}

{{- $gitalk := $comment.gitalk | default dict -}}

{{- if $gitalk.enable -}}

<div id="gitalk" class="comment"></div>

{{- $source := $cdn.gitalkCSS | default "lib/gitalk/gitalk.css" -}}

{{- dict "Source" $source "Minify" true "Fingerprint" $fingerprint | dict "Scratch" .Scratch "Data" | partial "scratch/style.html" -}}

{{- $source := $cdn.gitalkJS | default "lib/gitalk/gitalk.min.js" -}}

{{- dict "Source" $source "Fingerprint" $fingerprint | dict "Scratch" .Scratch "Data" | partial "scratch/script.html" -}}

{{- $commentConfig = dict "id" .Date "title" .Title "clientID" $gitalk.clientId "clientSecret" $gitalk.clientSecret "repo" $gitalk.repo "owner" $gitalk.owner "admin" (slice $gitalk.owner) | dict "gitalk" | merge $commentConfig -}}

<noscript>

Please enable JavaScript to view the comments powered by <a href="https://github.com/gitalk/gitalk"></a>Gitalk</a>.

</noscript>

{{- end -}}

We have the script partial page for this, and we can use also the file from the jsdelivr.yml file. Also, as a default value, it would be nice to have a local copy of the twikoo/waline scripts files. They are stored in this location: assets/lib.

I tried...but I only learned javascript for a few weeks...I hope you can help adjust if necessary

victor-pogor · 2021-07-14T18:15:54Z

layouts/posts/single.html

+                    <span id="{{ .RelPermalink }}" class="leancloud_visitors" data-flag-title="{{ .Title }}">
+                        <i class="far fa-eye fa-fw"></i>&nbsp;<span class=leancloud-visitors-count></span>&nbsp;{{ T "views" }}
+                    </span>&nbsp;
+					<a href="#comments" id="post-meta-vcount" title="{{ T `viewComments` }}">


The indentation should be the same as is on the 65th line.

May be done ?

…indentation

victor-pogor · 2021-07-19T17:53:55Z

assets/lib/VERSION

@@ -24,3 +24,5 @@ [email protected] https://github.com/metowolf/MetingJS
 [email protected] https://github.com/gitalk/gitalk
 [email protected] https://valine.js.org/
 [email protected] https://github.com/osano/cookieconsent
+[email protected] https://github.com/imaegoo/twikoo


@OnlyFor did you use some packaging tool or did you manually update this file? I'm asking this because I don't know how this file was generated ))

I……manually update this file……

No worries. I just asked. I thought maybe there is some package manager tool.

victor-pogor · 2021-07-19T17:57:33Z

exampleSite/content/posts/theme-documentation-basics/index.en.md

@@ -563,6 +563,17 @@ Please open the code block below to view the complete sample configuration :(far
        label = ""
        lightTheme = "github-light"
        darkTheme = "github-dark"
+      # {{< link "https://waline.js.org/en/" "Waline" >}} comment config


Can you also add this shortcode: {{< version 0.2.0 >}}

The result will look something like this:

victor-pogor

Good job. Thank you !!!

victor-pogor · 2021-07-22T18:03:30Z

assets/lib/VERSION

@@ -24,3 +24,5 @@ [email protected] https://github.com/metowolf/MetingJS
 [email protected] https://github.com/gitalk/gitalk
 [email protected] https://valine.js.org/
 [email protected] https://github.com/osano/cookieconsent
+[email protected] https://github.com/imaegoo/twikoo


No worries. I just asked. I thought maybe there is some package manager tool.

victor-pogor · 2021-07-22T18:05:03Z

@all-contributors please add @OnlyFor for code, docs

allcontributors · 2021-07-22T18:05:12Z

@victor-pogor

I've put up a pull request to add @OnlyFor! 🎉

victor-pogor and others added 28 commits May 2, 2021 22:23

Merge pull request #184 from sunt-programator/dev

2fd48f9

release: 0.1.2

build(npm): updated packages

d50863d

build(npm): updated packages

272899d

build(npm): updated packages

5cedad5

build(npm): updated packages

fe9ee8c

docs: update README.md [skip ci]

bd1368e

docs: update .all-contributorsrc [skip ci]

25e10de

Merge pull request #203 from sunt-programator/all-contributors/add-ai…

646748c

…yasin docs: add aiyasin as a contributor

build(npm): updated packages

9904b35

build(npm): updated packages

fab6811

build(npm): updated packages

1fdda4d

fix(gist): fixed the lost of indentation

0f2081d

fix(gist): fixed the lost of indentation

650a791

RE #173 Use the selector already included with PR #173

docs: update README.md [skip ci]

de65a1d

docs: update .all-contributorsrc [skip ci]

a7c218c

build(npm): updated packages

01ed5d2

build: ignored the 'missing Instagram AccessToken' error

248048c

Merge pull request #226 from aplatanado/fix/gist-indents

1e4a013

fix(gist): fixed the lost of indentation

Merge pull request #229 from sunt-programator/all-contributors/add-ap…

bdb018a

…latanado docs: add aplatanado as a contributor for code

docs: update README.md [skip ci]

59fb620

docs: update .all-contributorsrc [skip ci]

ac5914c

Merge pull request #236 from sunt-programator/all-contributors/add-kt…

d1fa357

…w717 docs: add ktw717 as a contributor for code, doc

build(npm): updated packages

a74cdcf

support twikoo comment system

6c3f99f

add twikoo sample config

df4fb33

fix config sample & add no script

525df8d

support waline comment system

d23c24c

Update config.toml

8a83c59

OnlyFor mentioned this pull request Jul 14, 2021

[FEATURE] 增加 waline 评论系统 #237

Closed

victor-pogor suggested changes Jul 14, 2021

View reviewed changes

OnlyFor added 2 commits July 15, 2021 20:10

update jsdeliver & update lib files & update config and doc & update …

be07d9b

…indentation

Update comment.html

0ce0bee

victor-pogor reviewed Jul 19, 2021

View reviewed changes

OnlyFor added 2 commits July 20, 2021 21:46

Update VERSION

ef9ae9d

add {{< version 0.2.0 >}}

2134405

victor-pogor approved these changes Jul 22, 2021

View reviewed changes

allcontributors bot mentioned this pull request Jul 22, 2021

docs: add OnlyFor as a contributor for code, doc #245

Merged

victor-pogor changed the base branch from master to dev July 22, 2021 18:09

victor-pogor merged commit a4a4d7b into sunt-programator:dev Jul 22, 2021

victor-pogor linked an issue Jul 22, 2021 that may be closed by this pull request

[FEATURE] 增加 waline 评论系统 #237

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support twikoo comment system #239

support twikoo comment system #239

OnlyFor commented Jul 14, 2021

victor-pogor left a comment •

edited

Loading

victor-pogor Jul 14, 2021

OnlyFor Jul 15, 2021

victor-pogor Jul 14, 2021

OnlyFor Jul 15, 2021

victor-pogor Jul 14, 2021

OnlyFor Jul 15, 2021

victor-pogor Jul 14, 2021

OnlyFor Jul 15, 2021

victor-pogor Jul 19, 2021 •

edited

Loading

OnlyFor Jul 20, 2021

victor-pogor Jul 22, 2021

victor-pogor Jul 19, 2021 •

edited

Loading

OnlyFor Jul 20, 2021

victor-pogor left a comment

victor-pogor Jul 22, 2021

victor-pogor commented Jul 22, 2021

allcontributors bot commented Jul 22, 2021

	{{- /* Gitalk Comment System */ -}}
	{{- $gitalk := $comment.gitalk \| default dict -}}
	{{- if $gitalk.enable -}}
	<div id="gitalk" class="comment"></div>
	{{- $source := $cdn.gitalkCSS \| default "lib/gitalk/gitalk.css" -}}
	{{- dict "Source" $source "Minify" true "Fingerprint" $fingerprint \| dict "Scratch" .Scratch "Data" \| partial "scratch/style.html" -}}
	{{- $source := $cdn.gitalkJS \| default "lib/gitalk/gitalk.min.js" -}}
	{{- dict "Source" $source "Fingerprint" $fingerprint \| dict "Scratch" .Scratch "Data" \| partial "scratch/script.html" -}}
	{{- $commentConfig = dict "id" .Date "title" .Title "clientID" $gitalk.clientId "clientSecret" $gitalk.clientSecret "repo" $gitalk.repo "owner" $gitalk.owner "admin" (slice $gitalk.owner) \| dict "gitalk" \| merge $commentConfig -}}
	<noscript>
	Please enable JavaScript to view the comments powered by <a href="https://github.com/gitalk/gitalk"></a>Gitalk</a>.
	</noscript>
	{{- end -}}

support twikoo comment system #239

support twikoo comment system #239

Conversation

OnlyFor commented Jul 14, 2021

victor-pogor left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victor-pogor Jul 19, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victor-pogor Jul 19, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victor-pogor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victor-pogor commented Jul 22, 2021

allcontributors bot commented Jul 22, 2021

victor-pogor left a comment •

edited

Loading

victor-pogor Jul 19, 2021 •

edited

Loading

victor-pogor Jul 19, 2021 •

edited

Loading