firebase init #12
Merged
firebase init #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Your web app's Firebase configuration | ||
| // For Firebase JS SDK v7.20.0 and later, measurementId is optional | ||
| const firebaseConfig = { |
There was a problem hiding this comment.
The secret keys should not be pushed to github... They should be in an .env file
|
Visit the preview URL for this PR (updated for commit 3c7702f): https://px-0-d6b35--pr12-dev-zd9oxkeq.web.app (expires Thu, 19 Sep 2024 09:47:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: caad915502cf758d1b029d1af8b0f6ad4618c1c0 |
SammyMusyoki
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.