Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: social aith buttons icon only option #43

Conversation

Csierram96
Copy link
Contributor

What kind of change does this PR introduce?

  • Add option to show the social auth buttons as icons only.
  • This is branched off the fix/social-button branch, so it includes those changes. This PR might need to be adjusted once that PR merges.

Bug fix, feature, docs update, ...

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@Csierram96
Copy link
Contributor Author

Csierram96 commented Feb 28, 2023

sorry about some of the auto-formatting.
If you like the changes, I can remove the formatting changes, add a better PR description.
Also, this is branched off the fix/social-button branch, so it includes those changes. This PR might need to be adjusted once that PR merges.
Let me know what you think. Thanks!! cc: @dshukertjr

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Csierram96 I love this update! It's a great idea to have the icons-only option!

@dshukertjr
Copy link
Member

Thanks for updating the code! Let's wait for #42 to merge and then take care of this PR!

@dshukertjr
Copy link
Member

Okay, the other PR is merged!

@Csierram96 Csierram96 force-pushed the feat/social-auth-buttons-icon-only branch from f8f2e8d to 0569169 Compare March 4, 2023 15:24
@Csierram96
Copy link
Contributor Author

I updated the PR based on the latest main branch.
There are 2 things that we need to look at:

  1. What behaviour do we want when the icons do not fit on the screen. This will happen as the the icons are now in a row instead of a column. A possible solution is wrapping the row in a wrap.
  2. For the majority of the icons, the icon color is black, and will look like this. This one can be addressed as part of a next PR.

image

image

@Csierram96
Copy link
Contributor Author

Replacing the Row with a wrap looks like this:

image

image

image

image

image

@Csierram96 Csierram96 force-pushed the feat/social-auth-buttons-icon-only branch from 0569169 to 44789b3 Compare March 4, 2023 15:34
@Csierram96 Csierram96 force-pushed the feat/social-auth-buttons-icon-only branch from 44789b3 to e3c2ed6 Compare March 7, 2023 13:29
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Csierram96
Thanks for this amazing update! Have you received Supabase swag before? If not, I can send you swag code via Twitter DM!

@dshukertjr dshukertjr merged commit 056b596 into supabase-community:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants