fix: error in client update

supabase · Oct 19, 2021 · a653408 · a653408
1 parent 9870078
commit a653408
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/gotrue/_async/client.py b/gotrue/_async/client.py
@@ -269,11 +269,11 @@ async def verify_otp(
             self._notify_all_subscribers(event=AuthChangeEvent.SIGNED_IN)
         return response
 
-    async def user(self) -> Optional[User]:
+    def user(self) -> Optional[User]:
         """Returns the user data, if there is a logged in user."""
         return self.current_user
 
-    async def session(self) -> Optional[Session]:
+    def session(self) -> Optional[Session]:
         """Returns the session data, if there is an active session."""
         return self.current_session
 
@@ -312,7 +312,8 @@ async def update(self, *, attributes: UserAttributes) -> User:
             jwt=self.current_session.access_token,
             attributes=attributes,
         )
-        self.current_user = response
+        self.current_session.user = response
+        await self._save_session(session=self.current_session)
         self._notify_all_subscribers(event=AuthChangeEvent.USER_UPDATED)
         return response
 
@@ -596,10 +597,6 @@ def _notify_all_subscribers(self, *, event: AuthChangeEvent) -> None:
 
     async def _save_session(self, *, session: Session) -> None:
         """Save session to client."""
-        if not session.user:
-            raise ValueError("User of session is None")
-        if not session.expires_in:
-            raise ValueError("Expires_in of session is None or empty")
         self.current_session = session
         self.current_user = session.user
         if session.expires_at:

diff --git a/gotrue/_sync/client.py b/gotrue/_sync/client.py
@@ -312,7 +312,8 @@ def update(self, *, attributes: UserAttributes) -> User:
             jwt=self.current_session.access_token,
             attributes=attributes,
         )
-        self.current_user = response
+        self.current_session.user = response
+        self._save_session(session=self.current_session)
         self._notify_all_subscribers(event=AuthChangeEvent.USER_UPDATED)
         return response
 
@@ -588,10 +589,6 @@ def _notify_all_subscribers(self, *, event: AuthChangeEvent) -> None:
 
     def _save_session(self, *, session: Session) -> None:
         """Save session to client."""
-        if not session.user:
-            raise ValueError("User of session is None")
-        if not session.expires_in:
-            raise ValueError("Expires_in of session is None or empty")
         self.current_session = session
         self.current_user = session.user
         if session.expires_at: