Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle user banned error code #1851

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: handle user banned error code #1851

merged 2 commits into from
Dec 13, 2024

Conversation

J0
Copy link
Contributor

@J0 J0 commented Nov 28, 2024

What kind of change does this PR introduce?

Currently, the user banned error code is masked - we surface HTTP errors including the user_banned error code

Need to:

  • Manually test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12134508143

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 56.991%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/token_oidc.go 0 2 0.0%
Totals Coverage Status
Change from base Build 12045179447: -0.007%
Covered Lines: 9546
Relevant Lines: 16750

💛 - Coveralls

@J0 J0 marked this pull request as ready for review December 11, 2024 09:57
@J0 J0 requested a review from a team as a code owner December 11, 2024 09:57
@J0 J0 merged commit a6918f4 into master Dec 13, 2024
6 checks passed
@J0 J0 deleted the j0/update_error_code_id_token branch December 13, 2024 02:44
hf pushed a commit that referenced this pull request Dec 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.165.1](v2.165.0...v2.165.1)
(2024-12-19)


### Bug Fixes

* check if session is nil
([#1873](#1873))
([fd82601](fd82601))
* email_verified field not being updated on signup confirmation
([#1868](#1868))
([483463e](483463e))
* handle user banned error code
([#1851](#1851))
([a6918f4](a6918f4))
* Revert "fix: revert fallback on btree indexes when hash is
unavailable" ([#1859](#1859))
([9fe5b1e](9fe5b1e))
* skip cleanup for non-2xx status
([#1877](#1877))
([f572ced](f572ced))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hf pushed a commit that referenced this pull request Dec 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.166.0](v2.165.0...v2.166.0)
(2024-12-23)


### Features

* switch to googleapis/release-please-action, bump to 2.166.0
([#1883](#1883))
([11a312f](11a312f))


### Bug Fixes

* check if session is nil
([#1873](#1873))
([fd82601](fd82601))
* email_verified field not being updated on signup confirmation
([#1868](#1868))
([483463e](483463e))
* handle user banned error code
([#1851](#1851))
([a6918f4](a6918f4))
* Revert "fix: revert fallback on btree indexes when hash is
unavailable" ([#1859](#1859))
([9fe5b1e](9fe5b1e))
* skip cleanup for non-2xx status
([#1877](#1877))
([f572ced](f572ced))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants