-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
older pythons are broken due to NotRequired #343
Comments
Your test-suite seems to run against 3.12 on all jobs...
|
@ap-- thanks for reporting this. Also we will look into the tests not running against the correct version of Python. |
The issue seems to be this one: abatilo/actions-poetry#72 |
🤔 releasing a new version without fixing the tests does not seem to be a great solution. You could have just yanked |
Don't have direct access to PyPi at the moment so releasing a new version is quicker than yanking an old version. |
Thanks for the quick resolution ❤ . And it's good to see the test pass after #346 for all supported python versions. |
@ap-- thank you for reporting the issue and also pointing to where our tests were wrong and a solution to it too. I've started adding this to all the other python library repos as it affects more than just this library. Thanks once again. |
Python3.10 is currently broken due to #339
typing.NotRequired
requires 3.11 https://docs.python.org/3/library/typing.html#typing.NotRequiredThe text was updated successfully, but these errors were encountered: