Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

older pythons are broken due to NotRequired #343

Closed
ap-- opened this issue Jan 29, 2025 · 7 comments · Fixed by #344
Closed

older pythons are broken due to NotRequired #343

ap-- opened this issue Jan 29, 2025 · 7 comments · Fixed by #344
Assignees
Labels
bug Something isn't working

Comments

@ap--
Copy link

ap-- commented Jan 29, 2025

Python3.10 is currently broken due to #339

typing.NotRequired requires 3.11 https://docs.python.org/3/library/typing.html#typing.NotRequired

@ap--
Copy link
Author

ap-- commented Jan 29, 2025

juancarlospaco added a commit to juancarlospaco/storage-py that referenced this issue Jan 29, 2025
@silentworks silentworks reopened this Jan 29, 2025
@silentworks
Copy link
Collaborator

@ap-- thanks for reporting this. Also we will look into the tests not running against the correct version of Python.

@silentworks silentworks self-assigned this Jan 29, 2025
@silentworks silentworks added the bug Something isn't working label Jan 29, 2025
@ap--
Copy link
Author

ap-- commented Jan 29, 2025

The issue seems to be this one: abatilo/actions-poetry#72

@ap--
Copy link
Author

ap-- commented Jan 29, 2025

Also we will look into the tests not running against the correct version of Python.

🤔 releasing a new version without fixing the tests does not seem to be a great solution. You could have just yanked 0.11.2 to buy more time...

@silentworks
Copy link
Collaborator

silentworks commented Jan 29, 2025

Don't have direct access to PyPi at the moment so releasing a new version is quicker than yanking an old version.

@ap--
Copy link
Author

ap-- commented Jan 29, 2025

Thanks for the quick resolution ❤ . And it's good to see the test pass after #346 for all supported python versions.

@silentworks
Copy link
Collaborator

@ap-- thank you for reporting the issue and also pointing to where our tests were wrong and a solution to it too. I've started adding this to all the other python library repos as it affects more than just this library. Thanks once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants