Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exists method raises error when no file found #335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: exists method raises error when no file found #335

wants to merge 1 commit into from

Conversation

silentworks
Copy link
Collaborator

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

.exists method is raising an exception when a file is not found

What is the new behavior?

.exists method is returning false when a file is not found

Additional context

Add any other context or screenshots.

@silentworks silentworks requested a review from grdsdev January 18, 2025 23:45
@silentworks silentworks linked an issue Jan 18, 2025 that may be closed by this pull request
exists method throws if file does not exist #333
Open
@coveralls
Copy link

coveralls commented Jan 18, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12848405494

Details

  • 6 of 10 (60.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 83.709%
Changes Missing Coverage Covered Lines Changed/Added Lines %
storage3/_async/file_api.py 3 5 60.0%
storage3/_sync/file_api.py 3 5 60.0%
Totals Coverage Status
Change from base Build 12659581505: -0.5%
Covered Lines: 483
Relevant Lines: 577
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jan 18, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12848405494

Details

  • 6 of 10 (60.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 83.709%
Changes Missing Coverage Covered Lines Changed/Added Lines %
storage3/_async/file_api.py 3 5 60.0%
storage3/_sync/file_api.py 3 5 60.0%
Totals Coverage Status
Change from base Build 12659581505: -0.5%
Covered Lines: 483
Relevant Lines: 577
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grdsdev grdsdev Awaiting requested review from grdsdev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exists method throws if file does not exist
2 participants
@silentworks @coveralls