-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add storage client timeout #381
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 2.69%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's nice we're making the storage client also an instance variable on supabase.Client
, it being accessible through the .storage()
method while all the others are instance variables was a bit confusing 😄
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #381 +/- ##
===========================================
+ Coverage 78.75% 80.23% +1.48%
===========================================
Files 9 9
Lines 160 167 +7
===========================================
+ Hits 126 134 +8
+ Misses 34 33 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
No description provided.