Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add storage client timeout #381

Merged
merged 6 commits into from
Mar 9, 2023
Merged

fix: add storage client timeout #381

merged 6 commits into from
Mar 9, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Feb 21, 2023

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 21, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.69%.

Quality metrics Before After Change
Complexity 3.90 ⭐ 4.19 ⭐ 0.29 👎
Method Length 45.67 ⭐ 48.87 ⭐ 3.20 👎
Working memory 9.93 😞 10.94 😞 1.01 👎
Quality 66.52% 🙂 63.83% 🙂 -2.69% 👎
Other metrics Before After Change
Lines 221 240 19
Changed files Quality Before Quality After Quality Change
supabase/__version__.py 100.00% ⭐ 100.00% ⭐ 0.00%
supabase/client.py 67.80% 🙂 65.89% 🙂 -1.91% 👎
supabase/lib/client_options.py 58.59% 🙂 53.28% 🙂 -5.31% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
supabase/client.py Client.__init__ 6 ⭐ 235 ⛔ 16 ⛔ 41.16% 😞 Try splitting into smaller methods. Extract out complex expressions
supabase/lib/client_options.py ClientOptions.replace 9 🙂 122 😞 14 😞 50.73% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Copy link
Contributor

@anand2312 anand2312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's nice we're making the storage client also an instance variable on supabase.Client, it being accessible through the .storage() method while all the others are instance variables was a bit confusing 😄

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.48 🎉

Comparison is base (cded695) 78.75% compared to head (51d7792) 80.23%.

❗ Current head 51d7792 differs from pull request most recent head 57b340b. Consider uploading reports for the commit 57b340b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #381      +/-   ##
===========================================
+ Coverage    78.75%   80.23%   +1.48%     
===========================================
  Files            9        9              
  Lines          160      167       +7     
===========================================
+ Hits           126      134       +8     
+ Misses          34       33       -1     
Impacted Files Coverage Δ
supabase/client.py 93.75% <100.00%> (+1.94%) ⬆️
supabase/lib/client_options.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@J0 J0 merged commit 28fe522 into develop Mar 9, 2023
@J0 J0 deleted the j0/add_storage_timeout branch March 9, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants