Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class library(GUI): rename arguments - *new #1288

Merged
merged 1 commit into from
Dec 29, 2014

Conversation

gurk
Copy link
Contributor

@gurk gurk commented Dec 28, 2014

affects classes: NumberBox and StaticText

Other GUI views appear to use the convention *new(parent, bounds),
whereas above classes use *new(aParent, aBounds).

Problematic when using named arguments, e.g:

(
b = Rect(0, 0, 4, 4);
ListView.new(bounds: b);         // fine
NumberBox.new(bounds: b);        // not fine
StaticText.new(bounds: b);
)

    affects: NumberBox and StaticText
telephon added a commit that referenced this pull request Dec 29, 2014
class library(GUI): rename arguments - *new
@telephon telephon merged commit 2cbc898 into supercollider:master Dec 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants