Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use annotations to declare schema #2656

Conversation

blythed
Copy link
Collaborator

@blythed blythed commented Nov 29, 2024

from superduper.misc.typing import *

class MyComponent(Component):
    path: File
    my_func: Blob

@blythed blythed force-pushed the feature/2649/auto-infer-schema-from-annotations branch 3 times, most recently from f9a9302 to 0447d68 Compare November 29, 2024 15:39
@blythed blythed linked an issue Nov 30, 2024 that may be closed by this pull request
Copy link
Collaborator

@jieguangzhou jieguangzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case for this

from superduper.misc.typing import *

class MyComponent(Component):
    path: File
    my_func: Blob

@blythed blythed force-pushed the feature/2649/auto-infer-schema-from-annotations branch from 0447d68 to 5daeebc Compare January 14, 2025 20:29
@blythed blythed force-pushed the feature/2649/auto-infer-schema-from-annotations branch from 5daeebc to 37e07b0 Compare January 14, 2025 20:44
@blythed
Copy link
Collaborator Author

blythed commented Jan 14, 2025

Please add a test case for this

from superduper.misc.typing import *

class MyComponent(Component):
    path: File
    my_func: Blob

Done.

@blythed blythed merged commit c26aebd into superduper-io:main Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DATATYPE] Auto-infer _fields based on annotations File, Blob, etc.
2 participants