Refactor/2479/simplify databackend contract #2710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still to do:
|
blythed
force-pushed
the
refactor/2479/simplify-databackend-contract
branch
3 times, most recently
from
9b12350 to
28e92a0
Compare
Resolved |
| return query.limit(1).execute()[0] | ||
|
|
||
| def _wrap_results(self, query: Query, result, schema): | ||
| pid = self.primary_id(query) |
There was a problem hiding this comment.
Errors will occur for tables not created by SuperDuper. For example, tables that already exist in database cannot have their schema and primary_id retrieved.
There was a problem hiding this comment.
- Insert data into a table using a non-superduper method (such as ibis, SQL queries, etc.)
- Query the data from this table using superduper.
An error should occur.
Comment on lines
+119
to
+132
| def test_filter(db): | ||
| db.cfg.auto_schema = True | ||
|
|
||
| db['documents'].insert([{'x': i} for i in range(10)]) | ||
|
|
||
| t = db['documents'] | ||
|
|
||
| q = t.filter(t['x'] == 1) | ||
|
|
||
| results = q.execute() | ||
|
|
||
| assert len(results) == 1 | ||
|
|
||
| assert results[0]['x'] == 1 |
There was a problem hiding this comment.
We also need to test multiple conditions and difference conditions
difference conditions:
- isin
>- "!="
- ...
blythed
force-pushed
the
refactor/2479/simplify-databackend-contract
branch
3 times, most recently
from
2db34b1 to
e80debb
Compare
blythed
force-pushed
the
refactor/2479/simplify-databackend-contract
branch
from
e80debb to
70b2929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
superduper.backends.base.query.Querysuperduper_<impl>.Databackendt.insert(...)instead oft.insert().execute()since we don't need to serialize insertionst.update,t.deletedeprecatedt.filter(...).select(...).outputs(...), ort.like().(...)ort.(...).like()t.get()to get one data point (eager)t.ids()to get the ids (eager)t.subset(ids)to subset a queryt.limit(n, offset=m)to get a chunk of data.execute()no longer returns a cursor, instead a simple listt.column == x, replace witht['column'] == xq.dict()['documents']