Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NatSpec integration review #63

Closed
hellwolf opened this issue Aug 17, 2020 · 3 comments
Closed

NatSpec integration review #63

hellwolf opened this issue Aug 17, 2020 · 3 comments
Labels
Resolution: Wontfix This will not be worked on Type: Bug Something isn't working

Comments

@hellwolf
Copy link
Contributor

Check if NatSpec integration is properly incorporated.

ACs:

  • NatSpec shipped with json ABIs.
  • UIs showing NatSpec enabled transaction description properly.
@hellwolf hellwolf added the Type: Bug Something isn't working label Aug 17, 2020
@hellwolf hellwolf changed the title NatSpec integration check NatSpec integration validation Aug 17, 2020
@hellwolf hellwolf changed the title NatSpec integration validation NatSpec integration status check Aug 17, 2020
@hellwolf hellwolf changed the title NatSpec integration status check NatSpec integration review Aug 17, 2020
@hellwolf
Copy link
Contributor Author

Since we use proxy functions: callApp/callAgreement, batchCall and their meta tx companion calls, we are screwed. It is the same problem gnosis safe wallet has.

@hellwolf hellwolf added the Resolution: Wontfix This will not be worked on label Sep 9, 2020
@hellwolf
Copy link
Contributor Author

hellwolf commented Sep 9, 2020

due to the usage of callX and batchCall, radspec is no longer an option.

@hellwolf hellwolf closed this as completed Sep 9, 2020
@hellwolf
Copy link
Contributor Author

hellwolf commented Sep 9, 2020

replaced by #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Wontfix This will not be worked on Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hellwolf