Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] ERC-712 type signature based meta tx support #68

Closed
hellwolf opened this issue Sep 9, 2020 · 2 comments
Closed

[ETHEREUM-CONTRACTS] ERC-712 type signature based meta tx support #68

hellwolf opened this issue Sep 9, 2020 · 2 comments
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Tag: Idea Raw idea, questions, thoughts and brainstorming notes Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps
Milestone
ethereum-contrac...

Comments

@hellwolf
Copy link
Contributor

hellwolf commented Sep 9, 2020 •
edited
Loading

Rationale

With typed signature specified in ERC-712, batch operations could be signed in a human readable way in supported wallet interface.

It provides a great UX improvement, as an alternative to the radspec approach.

Target release: v0.2

Spec

  • TODO

ACs

  • TODO

Notes

  • function selector could be part of the typed signature, looking like "foobar(address,uint256)". The function name part is the human readable part, however the parameter list unfortunately cannot be ommitted.
  • the signed signature could be relayed as a meta tx, and be broadcasted by the user directly.
  • should review delegatable framework for composable 712 signatures.
@hellwolf hellwolf added the Type: Enhancement New feature or request label Sep 9, 2020
@hellwolf hellwolf mentioned this issue Sep 9, 2020
Closed
@hellwolf hellwolf modified the milestones: v0.1, v0.2 Sep 9, 2020
@hellwolf hellwolf changed the title ERC-712/Typed Signature Tx Support Meta Tx Support Nov 28, 2020
@hellwolf hellwolf changed the title Meta Tx Support ERC-712 type signature based meta tx support Nov 28, 2020
@hellwolf hellwolf modified the milestones: v0.2, v1.0 Nov 28, 2020
@hellwolf hellwolf added the review label Jan 1, 2021
@hellwolf hellwolf removed this from the v1.0 milestone Jan 16, 2021
@hellwolf hellwolf added Tag: Idea Raw idea, questions, thoughts and brainstorming notes and removed review labels Jun 7, 2021
@hellwolf hellwolf removed the Type: Enhancement New feature or request label Sep 20, 2021
saflamini pushed a commit that referenced this issue Oct 16, 2021
@austintgriffith
Merge pull request #68 from austintgriffith/add-hardhat
c9f7d9b 
Buidler -> Hardhat
@hellwolf hellwolf changed the title ERC-712 type signature based meta tx support [ETHEREUM-CONTRACTS] ERC-712 type signature based meta tx support Aug 30, 2022
@0xdavinchee
Copy link
Contributor

https://delegatable.org/

@hellwolf hellwolf added the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Aug 23, 2023
@hellwolf hellwolf added the Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity label Jan 18, 2024
@hellwolf hellwolf mentioned this issue Jan 18, 2024
Closed
8 tasks
@hellwolf
Copy link
Contributor Author

hellwolf commented Jan 23, 2024 •
edited
Loading

Closing in favor of #1782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Tag: Idea Raw idea, questions, thoughts and brainstorming notes Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps
Projects
None yet
Milestone
[email protected] - Giga
Development

No branches or pull requests
2 participants
@hellwolf @0xdavinchee