Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Japanese translation. #11

Merged
merged 3 commits into from
Jul 8, 2019
Merged

Add Japanese translation. #11

merged 3 commits into from
Jul 8, 2019

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jul 5, 2019

image
image

@superruzafa
Copy link
Owner

It looks like you tried to make use of the reduce.2.svg image before being created at #6.
I'll trigger the build check.

@exoego exoego force-pushed the add-ja-translation branch from 86396f7 to a1c109d Compare July 5, 2019 09:36
@exoego exoego marked this pull request as ready for review July 5, 2019 09:44
superruzafa
superruzafa reviewed Jul 5, 2019
View reviewed changes
_ja/functions/concat.md Outdated Show resolved Hide resolved
superruzafa
superruzafa reviewed Jul 5, 2019
View reviewed changes
_ja/functions/const.md Outdated Show resolved Hide resolved
superruzafa
superruzafa reviewed Jul 5, 2019
View reviewed changes
_ja/functions/unzip3.md Outdated Show resolved Hide resolved
superruzafa
superruzafa requested changes Jul 5, 2019
View reviewed changes
Copy link
Owner

@superruzafa superruzafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but there are some changes that need to be fixed.

@exoego exoego force-pushed the add-ja-translation branch from a1c109d to 84fe4fe Compare July 5, 2019 21:32
@superruzafa
Copy link
Owner

Hey @exoego, thanks a lot for your PR. A few considerations before going ahead with it:

Please, remove the andThen/compose additional paragraphs, they are not included in the original translation and it won't be included in that way. Related functions will be in a separate section in the future.
Please, mark conversations/changes as solved as I can be noticed you are done.
Try to no force push PR, in a large one like this it's easy to lost changes/modifications already fixed (at least filterNot, findLast, unzip3 contains errors in 84fe4fe).

Removed the additional paragraphs those not included in original.
f499d0c 
Those will be addressed in separate PR after discussion.
@exoego
Copy link
Contributor Author

exoego commented Jul 6, 2019

Thanks for such careful review !!

A reason why I squashed commits and force-pushed is that it is a custom in other OSS projects where non-essential commits should be squahed to keep commit history minimized and meaningful.
It is also a custom that reviwers mark conversations as solved so that reviwers confirms their comments resolved actually.

I can understand different custom so I follow it in this repo.

superruzafa
superruzafa reviewed Jul 8, 2019
View reviewed changes
_ja/functions/unzip3.md Outdated Show resolved Hide resolved
@superruzafa superruzafa merged commit 9287edc into superruzafa:master Jul 8, 2019
@exoego exoego deleted the add-ja-translation branch July 8, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superruzafa superruzafa superruzafa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exoego @superruzafa