Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Serve favicon.png #969

Closed
tsmethurst opened this issue Nov 6, 2022 · 1 comment · Fixed by #1850
Closed

[feature] Serve favicon.png #969

tsmethurst opened this issue Nov 6, 2022 · 1 comment · Fixed by #1850
Labels
enhancement New feature or request

Comments

@tsmethurst
Copy link
Contributor

Lots of apps and browsers try to load /favicon.png. We should add a handler to serve the same thing here that we serve for /assets/logo.png.
@tsmethurst tsmethurst added the enhancement New feature or request label Nov 6, 2022
@da2x
Copy link

da2x commented Nov 6, 2022

The convention is /favicon.ico using Windows icon files (not PNGs). This is only loaded when the document doesn’t contain a <link rel=icon>.

@tsmethurst tsmethurst mentioned this issue Dec 14, 2022
Merged
2 tasks
@tsmethurst tsmethurst mentioned this issue May 31, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore/frontend] Refactor header templating, add apple-touch-icon superseriousbusiness/gotosocial
2 participants
@da2x @tsmethurst