Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore/frontend] Refactor header templating, add apple-touch-icon #1850

Merged
merged 1 commit into from
May 31, 2023

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request refactors our header template file to use nested templates for repeated values, tidies up some formatting for readability, and updates our use of 'icon' to drop 'shortcut' and add apple values (https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel#icon)

Closes #969 by making it no longer necessary.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.

@tsmethurst tsmethurst requested a review from f0x52 May 31, 2023 11:43
Copy link
Contributor

@f0x52 f0x52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tsmethurst tsmethurst merged commit 23705b3 into main May 31, 2023
@tsmethurst tsmethurst deleted the header_template_refactor branch May 31, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Serve favicon.png
2 participants