Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer JSON errors in API endpoints #1766

Merged

Conversation

natsukagami
Copy link
Contributor

Description

Fixing a point mentioned in #1759 (comment)

  • Default to JSON over HTML for error handling
  • Change the default error display for web endpoints to html

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@natsukagami natsukagami force-pushed the prefer-json-errors-in-api branch from 39fc759 to 6d778d7 Compare May 11, 2023 18:39
@natsukagami natsukagami marked this pull request as ready for review May 11, 2023 18:40
@tsmethurst
Copy link
Contributor

Hell yeah, great work, thank you!

@tsmethurst tsmethurst merged commit ba5a464 into superseriousbusiness:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants