Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Don't stretch on very wide status'es #1956

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

daenney
Copy link
Member

@daenney daenney commented Jul 7, 2023

Description

If someone makes a post with a long, uninterrupted piece of text in a code snippet, we would stretch the column to fit it, resulting in the UI going a bit whacky.

By setting min-width: 0% this fixes it, and we now automatically get a scrollbar on overflow instead.

Fixes: #1952

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

If someone makes a post with a long, uninterrupted piece of text in a
code snippet, we would stretch the column to fit it, resulting in the
UI going a bit whacky.

By setting min-width: 0% this fixes it, and we now automatically get a
scrollbar on overflow instead.

Fixes: superseriousbusiness#1952
@daenney
Copy link
Member Author

daenney commented Jul 7, 2023

Before:

Screenshot from 2023-07-07 18-25-43

After:

Screenshot from 2023-07-07 18-26-10

@daenney daenney changed the title [bugfix] Don't overflow on very wide status'es [bugfix] Don't stretch on very wide status'es Jul 7, 2023
@tsmethurst tsmethurst merged commit 672386a into superseriousbusiness:main Jul 8, 2023
@tsmethurst
Copy link
Contributor

Nice!

@daenney daenney deleted the code-overflow branch July 8, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Codeblocks break responsivness of the page
2 participants