Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix inconsistent calculated cache sizes #2115

Conversation

NyaaaWhatsUpDoc
Copy link
Member

  • use pre-calculated exampleTime instead of time.Now() to ensure no locale data in example models
  • tweaks the cache memory ratios now the calculated sizes of changed
  • updates the default cache memory target to 100MiB, given the previous calculated sizes were smaller than they should be

for a more full explanation see the comment on var exampleTime in internal/cache/size.go

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member Author

the psychic damage tracking down this bug took years off my life

Copy link
Member

@daenney daenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time should've never been invented.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 815b529 into superseriousbusiness:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants