[chore] Add script for downloading latest snapshot tar.gz #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/get_latest_snapshot.sh
Outdated
| MINIO_ENDPOINT="https://${MINIO_HOST}/${MINIO_BUCKET}/${LATEST_HASH}/${GTS_FILENAME}" | ||
|
|
||
| echo "fetching latest snapshot tar.gz from endpoint '${MINIO_ENDPOINT}'" | ||
| wget --no-verbose -O "./${GTS_FILENAME}" "${MINIO_ENDPOINT}" |
There was a problem hiding this comment.
Why use wget here when we're already using curl above? If it's following redirects + setting output file you want then just do something like curl -sLo "./${GTS_FILENAME}" "${MINIO_ENDPOINT}"
There was a problem hiding this comment.
It would be nice to add something like --fail --retry 5 --retry-max-time 600 to "both" curl commands. That should make it a bit more robust in case something temporarily blips.
There was a problem hiding this comment.
Thank you comrades! Will fix this up tomorrow most likely :)
daenney
reviewed
Aug 29, 2023
daenney
reviewed
Aug 29, 2023
Co-authored-by: Daenney <[email protected]>
Co-authored-by: Daenney <[email protected]>
daenney
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a quick and fairly dirty bash script into the
scriptsdirectory that folks can use to pull the latest snapshot release tar.gz from our Minio S3 bucket.I didn't advertise it anywhere in the docs because it's not something we should really 'recommend' to people, but we can at least point it to folks who regularly run snapshots and want a very slightly easier way of doing it.
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]->[x]If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).