[bugfix] move SQLite pragmas into connection string #2171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title says really! Moves the SQLite connection pragmas into the connection string, just to ensure that all our connection preferences are set on every created new connection, considering that it's a little unclear what data is shared across SQLite connections. These are set using the
_pragma
URI query key as specified in themodernc.org/sqlite.Driver{}.Open()
documentation.An example of a connection string with this:
timestamp="01/09/2023 09:02:20.915" func=bundb.sqliteConn level=INFO msg="connected to SQLITE database with address file:/data/sqlite.db?_pragma=busy_timeout%28300000%29&_pragma=journal_mode%28WAL%29&_pragma=synchronous%28NORMAL%29&_pragma=cache_size%28-8192%29&_txlock=immediate"
Checklist
go fmt ./...
andgolangci-lint run
.