Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix checks for deref the same status descendants / ascendants #2181

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

See title. Also some little refactoring to increase code reuse, reduce log string length and hopefully provide more useful information in the case of tracing.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member Author

fixes #2174

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 916c6d0 into superseriousbusiness:main Sep 5, 2023
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the bugfix/still-recursing-pages-gaaaaaaaaaaah branch September 5, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants