Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] return 400 Bad Request on more cases of malformed AS data #2399

Conversation

NyaaaWhatsUpDoc
Copy link
Member

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc commented Nov 29, 2023

Description

Adds a "malformed" error value flag which we now set on parse-type failures during AS->internal conversions. These are then caught after PostInbox() and returned as 400 Bad Request errors appropriately. Also has some small tweaks here and there, and updates the go-errors package with some tweaks (which we should eventually incorporate in our own gtserror package too).

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member Author

linter is angry, and there's an error message in a test that needs updating. a job for later kim ... :]

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc marked this pull request as draft November 30, 2023 10:07
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc marked this pull request as ready for review November 30, 2023 10:45
@NyaaaWhatsUpDoc
Copy link
Member Author

closes #2145

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit eb17000 into superseriousbusiness:main Nov 30, 2023
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the bugfix/better-malformed-ap-errors branch November 30, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants