-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] return 400 Bad Request on more cases of malformed AS data #2399
Merged
NyaaaWhatsUpDoc
merged 8 commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:bugfix/better-malformed-ap-errors
Nov 30, 2023
Merged
[bugfix] return 400 Bad Request on more cases of malformed AS data #2399
NyaaaWhatsUpDoc
merged 8 commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:bugfix/better-malformed-ap-errors
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linter is angry, and there's an error message in a test that needs updating. a job for later kim ... :] |
closes #2145 |
tsmethurst
reviewed
Nov 30, 2023
tsmethurst
reviewed
Nov 30, 2023
tsmethurst
reviewed
Nov 30, 2023
tsmethurst
reviewed
Nov 30, 2023
tsmethurst
reviewed
Nov 30, 2023
tsmethurst
reviewed
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a "malformed" error value flag which we now set on parse-type failures during AS->internal conversions. These are then caught after PostInbox() and returned as 400 Bad Request errors appropriately. Also has some small tweaks here and there, and updates the
go-errors
package with some tweaks (which we should eventually incorporate in our owngtserror
package too).Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.