[feature] Allow import of following and blocks via CSV #3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmethurst
force-pushed
the
data_import
branch
2 times, most recently
from
131e067 to
0c1fad2
Compare
| defer file.Close() | ||
|
|
||
| // Parse records out of the file. | ||
| records, err := csv.NewReader(file).ReadAll() |
There was a problem hiding this comment.
not something that needs changing now, but worth bearing in mind for the future, if we end up dealing with biiiiiiig CSVs on constrained instances with quite a few people, this code might end up churning quite a lot of memory. if that does become the case then batch-processing (if the csv file reader allows returning small record batches at a time) would probably work with minimal logic changes
There was a problem hiding this comment.
though i suppose this isn't the most common API endpoint...
just musing to myself here. and hoping that you also get to see this too :D
|
great work 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Second part of (and depends on) #3140.
Adds data import functionality via Mastodon-formatted CSV files uploaded via the settings panel.
Just added following and blocks for now since they're probably the most useful ones, we can add the others later on (I wanted to keep the PR relatively small + reviewable).
Draft until #3140 is squerged, at which point I'll rebase this one and write some tests and all that jazz.Closes #1048
Closes #896 (more or less).
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]->[x]If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...andgolangci-lint run.