-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add global instance CSS customization setting #3352
[Feature] Add global instance CSS customization setting #3352
Conversation
Allow instance admins to add custom CSS that will affect every page of their instance. This is done with a new CustomCSS instance setting that works pretty much exactly like the Users CustomCSS property. This custom CSS is then requested for every page load. User styles/themes take precedence over this CSS.
Contrary to what I've said in the Issue, this will also affect the CSS in the dashboard. Again, no stress for the review, I know you're all busy with the 0.17 release. |
This is what's failing the tests but I can't seem to be able to reproduce it locally. Thoughts? |
Yes, just a flaky test I think, I'll re-run |
Great stuff, thank you! Sorry for the late review :') I'll get this branch up to date and squerge it. |
Hey cool, Thank you! |
Description
Allow instance admins to add custom CSS that will affect every page of their instance.
This is done with a new CustomCSS instance setting that works pretty much exactly like the Users CustomCSS property. This custom CSS is then requested for every page load. User styles/themes take precedence over this CSS.
closes #3348
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.