[bugfix] Store LastModified for domain perm subs + send as If-Modified-Since
#3655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a LastModified column to domain permission subscriptions, which is used to store the
Last-Modified
header (if any) returned from a domain perm subscription fetch. This value is then transmitted asIf-Modified-Since
along with subsequent requests instead of the LastSuccessfulFetch value, as a more reliable way of ensuring that remotes can return 304 if nothing has changed.(Also adds some docs I forgot to add before to the config.yaml example, oops.)
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.