[chore] remove type switch in Create() and instead move to FederatedCallbacks() #3697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is once again another part to #1891.
It moves the type switch out of the federatingDB{}.Create() function and instead handles them as separate functions that we pass in FederatedCallbacks(). Also has some other minor refactoring (no logic changes), and adds some new gtserror functions that should collapse some of our common error wrapping logic down to one-liners.
Checklist
go fmt ./...
andgolangci-lint run
.