Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove type switch in Create() and instead move to FederatedCallbacks() #3697

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

This is once again another part to #1891.

It moves the type switch out of the federatingDB{}.Create() function and instead handles them as separate functions that we pass in FederatedCallbacks(). Also has some other minor refactoring (no logic changes), and adds some new gtserror functions that should collapse some of our common error wrapping logic down to one-liners.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc marked this pull request as ready for review January 27, 2025 14:23
@tsmethurst
Copy link
Contributor

Oh great stuff :) Been meaning to do this for tiiiiiime

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 61141ac into superseriousbusiness:main Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants