[feature] Use maintenance router to serve 503 while server is starting/migrating #3705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a simple barebones router that's initialized during startup, hangs around until db migrations are complete, and then is closed and replaced with the "main" server router.
The maintenance router serves static assets, serves 200 OK for "live" checks (not "ready" checks), and serves a 503 page for everything else, with
Retry-After
set to 2 minutes.Should make things a little clearer for users when an instance is down running database migrations :) And should reassure admins that stuff is working, as well.
The command
gotosocial server maintenance
has also been added just to test the maintenance mode.Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.