Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Web Push: Use server URL for VAPID sub claim #3716

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

VyrCossont
Copy link
Contributor

Description

webpush-go now supports sending https:// as well as mailto: URLs for VAPID sub claims, so we can revert 464d920 now and save fetching the instance contact email or making up a dummy email if there wasn't one configured.

Tested on Safari, which was the only browser that cared about whether VAPID sub claims were even correctly formed.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

webpush-go now supports sending `https://` as well as `mailto:` URLs for VAPID sub claims, so we can revert 464d920 now and save fetching the instance contact email or making up a dummy email if there wasn't one configured.
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit fc895ad into main Jan 31, 2025
4 checks passed
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the webpush-go-https-subject branch January 31, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants