[chore] Web Push: Use server URL for VAPID sub claim #3716
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
webpush-go now supports sending
https://
as well asmailto:
URLs for VAPID sub claims, so we can revert 464d920 now and save fetching the instance contact email or making up a dummy email if there wasn't one configured.Tested on Safari, which was the only browser that cared about whether VAPID sub claims were even correctly formed.
Checklist
go fmt ./...
andgolangci-lint run
.