Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] update otel libraries #3740

Merged
merged 3 commits into from
Feb 6, 2025
Merged

[chore] update otel libraries #3740

merged 3 commits into from
Feb 6, 2025

Conversation

theSuess
Copy link
Contributor

@theSuess theSuess commented Feb 5, 2025 •
edited
Loading

Description

This PR updates the OpenTelemetry libraries and fixes associated issues through combining metrics and traces into a single observability package which can be excluded from compilation by providing the nootel flag.

Fixes #3338
Fixes #3117

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@theSuess theSuess force-pushed the chore/update-otel-libraries branch from eac8619 to a2a72b0 Compare February 5, 2025 17:04
@theSuess theSuess marked this pull request as ready for review February 5, 2025 17:28
@tsmethurst
Copy link
Contributor

Awesome, thank you!!!! 😍

@tsmethurst tsmethurst merged commit dd094e4 into superseriousbusiness:main Feb 6, 2025
3 checks passed
@NyaaaWhatsUpDoc
Copy link
Member

oh this is great stuff, thanks @theSuess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@theSuess @tsmethurst @NyaaaWhatsUpDoc