Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: makeBidRequestの不備 #5

Merged
1 commit merged into from
Oct 7, 2020
Merged

FIX: makeBidRequestの不備 #5

1 commit merged into from
Oct 7, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 2, 2020

以下コピペ

# prebidServerに手を入れる箇所
- transactionIdの追加
- UAをheaderに追加
- sizeの `× -> x`  に変更
- size -> sizes に変更
# 確認方法
- PrebidMobileAppを実装してみて確認する
    - https://github.com/prebid/prebid-mobile-ios

93245のBidIDにてローカル環境で確認済み
（ChromeのDevice Toolbarによる確認）

@ghost ghost requested review from nabata and banakemi October 2, 2020 10:09
@ghost ghost self-assigned this Oct 2, 2020
nabata
nabata approved these changes Oct 5, 2020
View reviewed changes
Copy link

@nabata nabata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fix: add UA to RequestHeader.
4a6ae5d 
fix: fix sizes query.
@ghost ghost force-pushed the fix/adg-makeRequest-params branch from 9fb6351 to 4a6ae5d Compare October 7, 2020 09:53
@ghost ghost merged commit e1dc82f into master Oct 7, 2020
@supership-jp supership-jp deleted a comment Jun 21, 2022
@supership-jp supership-jp deleted a comment Jun 21, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banakemi banakemi Awaiting requested review from banakemi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nabata