-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature email password #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kant01ne
force-pushed
the
feature-email-password
branch
from
October 27, 2020 08:22
79523a2
to
5565cfb
Compare
|
Fix #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Implement Router methods #12
Implement the SignInAndUpTheme #9
Implement the EmailPassword recipeModule #7
Implement the SignInAndUp Feature component #5
Implement the ResetPasswordUsingToken Feature Component #6
Implement the ResetPasswordUsingTokenTheme #10
Add a component library of reusable components including the following:
FormBase component for email password
Implement Email Password Feature for SignIn/SignUp (with tests)
Implement Email Password Theme for SignIn/SignUp (without tests just drafts)
Implement Email Password Feature for ResetPassword (with tests)
Implement Email Password Theme for ResetPassword (without tests just drafts)
Test app with different routes and designs (
npm run testapp
)Use
eslint
in favour oftslint
becausetslint
is being deprecated and becauseeslint
has a handy plugin for react-hooks usage.Remove SupertokensUrl
More robust test solution with react-test-app in tests folders and no need to delete/update node_modules and rerun npm_install
Routing algorithm abstraction
Recipe Email Password wrapper