Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After used
vuex-cache
code for a while I realize it's methods is very similar toMap
methods and doing some researches I also confirmed that Maps are better than pure objects(Object.create(null)
).So I'd changed
cache
constant to a Map instance, addeddispatch
method and expose it. Now all Map methods anddispatch
is available understore.cache
namespace. Also I'd changed the unit tests and README.In fact, now this lib is faster and smaller, and the only side effects is IE11- that needs Map polyfill to run properly.