Added handling for non-zero values excluding false
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrowski
reviewed
Jan 27, 2025
zap/zp_test.go
Outdated
| @@ -0,0 +1,187 @@ | |||
| package zap | |||
There was a problem hiding this comment.
rename file to zap_test.go
piotrowski
reviewed
Jan 27, 2025
zap/zp_test.go
Outdated
| value any | ||
| want []any | ||
| }{ | ||
| // Nil and Zero cases |
There was a problem hiding this comment.
comments not needed :) Just name test correctly
piotrowski
reviewed
Jan 27, 2025
zap/zp_test.go
Outdated
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| appendFilledFieldsOnly(&tt.fields, tt.key, tt.value) |
There was a problem hiding this comment.
You know key will always be string. Just remove this from here and use static "key" string.
Suggested change
| appendFilledFieldsOnly(&tt.fields, tt.key, tt.value) | |
| appendFilledFieldsOnly(&tt.fields, "key", tt.value) |
piotrowski
reviewed
Jan 27, 2025
zap/zp_test.go
Outdated
Comment on lines
165
to
171
| { | ||
| name: "nil key", | ||
| fields: []any{}, | ||
| key: "nil", | ||
| value: "value", | ||
| want: []any{"nil", "value"}, | ||
| }, |
There was a problem hiding this comment.
no need to test keys I believe :) string is string.
piotrowski
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.