Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple New Features Planned #26

Open
surfrock66 opened this issue Feb 4, 2019 · 4 comments
Open

Multiple New Features Planned #26

surfrock66 opened this issue Feb 4, 2019 · 4 comments

Comments

@surfrock66
Copy link
Owner

From forks, I want to implement the following features and fixes:

  1. Rely on "empty" and not !isset: aegixx@81a43a5
  2. Script for processing the upload of a session from a csv export in the torque app: adel-s@a1b3eb8
  3. Make the minimum session size configurable: adel-s@a0e6ff8
  4. Show events as map markers: adel-s@0f7113c
  5. Evaluate redundant result freeing: adel-s@825c59d
  6. Enable multiple user accounts: adel-s@bc5ece5
@stealer0517
Copy link

Not sure if this is the preferred way to add some feature requests, but I have two ideas that would be neat (and I'm far too dumb to figure out php).

  1. Ability to zoom on the chart, or set min/maxes to display on the chart.
    My mpg shoots up to 512 when I let go of the gas which makes it pretty much unusable.
    I figured out how to make the chart taller which helps a lot.

  2. Multiple charts.
    Say I want to view Engine temperature, and the RPM the difference between 30-180(f) and 800-3000 is huge.
    I'm sure this could be achieved with some copy pasting, but I'm seemingly too dumb to figure out the chart.

@surfrock66
Copy link
Owner Author

#6 in my list is done via this commit: 45e0747

surfrock66 added a commit that referenced this issue Mar 1, 2019
…mum session size is now configurable in the creds.php file. Thanks to adel-s for the code.
@surfrock66
Copy link
Owner Author

3 is done via commit cb06712
5 is done via commit c09c64a

@surfrock66
Copy link
Owner Author

I've done some research for 1 above, and I've decided to not implement this change; I may come back to it but for now the logic as I'm reading through works as is. Here's some research: https://www.virendrachandak.com/techtalk/php-isset-vs-empty-vs-is_null/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants