Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add ability set height based on content. #51

Merged
merged 19 commits into from
Apr 25, 2022
Merged

Feat: add ability set height based on content. #51

merged 19 commits into from
Apr 25, 2022

Conversation

KristinaZoteva
Copy link
Contributor

No description provided.

@KristinaZoteva
Chore: change default animation bottom sheet duration.
267b9e2
@KristinaZoteva
Docs: change docs to builder, added information that builder should r…
331955d 
…eturn a scrollable widget.
@KristinaZoteva
Merge branch 'main' into change_docs_to_builder
114ff9e
@KristinaZoteva
Work in progress: add post frame callback
ed171ba
@KristinaZoteva
feat: add Scaffold instead of Column and Expanded.
771475a
@KristinaZoteva
Chore: reverted animateToMaxHeight method changes.
7bdad96
@KristinaZoteva
Chore: reverted animateToMaxHeight method changes.
2e2a658
@KristinaZoteva
Chore: reverted animateToMaxHeight method changes.
6a8cbce
@KristinaZoteva
Feat: add safeArea.
1850b47
@KristinaZoteva
Improve: add example to bottom sheet based on content height. Add tests.
b644dc0
@KristinaZoteva
Improve: add example to bottom sheet based on content height. Add tests.
45f8c5c
@KristinaZoteva
Improve: add tests for modified behavior.
48cf368
@KristinaZoteva
Chore: removed check for headerBuilder for scrolling.
db7bbbf
@KristinaZoteva
Fix: add ability to pass decorated when calling showFlexibleBottomSheet.
4c62398 
Docs: improved docs and README.md.
@KristinaZoteva KristinaZoteva requested a review from MbIXjkee April 20, 2022 11:06
@KristinaZoteva KristinaZoteva self-assigned this Apr 20, 2022
@KristinaZoteva KristinaZoteva added enhancement New feature or request WIP Work in progress and removed enhancement New feature or request labels Apr 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #51 (8691ae5) into main (8f8fb6c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 8691ae5 differs from pull request most recent head 3480fd2. Consider uploading reports for the commit 3480fd2 to get more accurate results

@@            Coverage Diff            @@
##              main       #51   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          206       238   +32     
=========================================
+ Hits           206       238   +32
Impacted Files Coverage Δ
lib/src/flexible_bottom_sheet.dart 100.00% <100.00%> (ø)
lib/src/flexible_bottom_sheet_route.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8fb6c...3480fd2. Read the comment docs.

@KristinaZoteva KristinaZoteva removed the WIP Work in progress label Apr 20, 2022
@KristinaZoteva KristinaZoteva added the WIP Work in progress label Apr 22, 2022
@KristinaZoteva KristinaZoteva removed the WIP Work in progress label Apr 22, 2022
MbIXjkee
MbIXjkee approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@MbIXjkee MbIXjkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MbIXjkee MbIXjkee merged commit d31da47 into main Apr 25, 2022
@MbIXjkee MbIXjkee deleted the add_ability_set_height_based_on_content branch April 25, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MbIXjkee MbIXjkee MbIXjkee approved these changes

Assignees

@KristinaZoteva KristinaZoteva

Labels
new pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KristinaZoteva @codecov-commenter @MbIXjkee @github-secret