Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bug after closing the bottom sheet if it was opened with an open keyboard. #54

Merged
merged 23 commits into from
May 19, 2022

Conversation

KristinaZoteva
Copy link
Contributor

No description provided.

# Conflicts:
#	lib/src/flexible_bottom_sheet.dart
#	lib/src/flexible_bottom_sheet_route.dart
@codecov-commenter
Copy link

Codecov Report

Merging #54 (861b31b) into main (d31da47) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          240       244    +4     
=========================================
+ Hits           240       244    +4     
Impacted Files Coverage Δ
lib/src/widgets/change_insets_detector.dart 100.00% <ø> (ø)
lib/src/flexible_bottom_sheet.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d31da47...861b31b. Read the comment docs.

# Conflicts:
#	lib/src/flexible_bottom_sheet.dart
Copy link
Contributor

@MbIXjkee MbIXjkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MbIXjkee MbIXjkee merged commit dba4b00 into main May 19, 2022
@MbIXjkee MbIXjkee deleted the fix_error_after_closed_bottom_sheet branch May 19, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants