Optimize printFib using lists to build strings #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| num1 = num2; | ||
| num2 = num3; | ||
| } | ||
| return("Fibonacci Series : "+st); | ||
| return("Fibonacci Series : "+st.join(' ')); |
There was a problem hiding this comment.
I think there is no optimization here. and through the string.join() you have added another loop if you are not satisfied with my opinion please let me know.
There was a problem hiding this comment.
When you add to a string like s=s+'a' , you have to create a whole new new string, which is not a problem with short strings but can get a little inefficient with long strings, so with big strings adding to a list is constant time rather than making a whole new string.
The optimization is not that big, and in modern systems it is not that big of a difference, so if you want you can ignore this pull or include it, up to you.
There was a problem hiding this comment.
Yeah, you're right :)
suryapratapsinghsuryavanshi
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding to a string each time creates an entirely new string because strings are immutable in JS. Instead, we can just add to a list and turn it into a string at the end.