-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kepler): enable pprof #1383
Conversation
Signed-off-by: Sunil Thaha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sthaha Have you seen that we already have pprof support?
https://github.com/sustainable-computing-io/kepler/blob/main/cmd/exporter/exporter.go#L137
Hey @marceloamaral - while we can get a pprof with this, it isn't ideal at all. I tried to enumerate this in a document, but I will add it here -
|
@marceloamaral same arguments as @jtaleric . https://pkg.go.dev/runtime/pprof#hdr-Profiling_a_Go_program says
NOTE: I didn't remove the existing one since it may be added for a particular reason which I couldn't figure reading the git commits but that is a separate discussion which can be handled in a different PR. |
thank @sthaha, that makes sense. @marceloamaral would you take a look? Remote profiling is helpful for online debuggin. |
Let's try to clean the code and have only one approach. |
The commit - f5910e2 adds pprof HTTP endpoints to kepler thus removing the need to support -cpu-profile or -memory-profile explicitly. See also: sustainable-computing-io#1383 Signed-off-by: Sunil Thaha <[email protected]>
The commit - f5910e2 adds pprof HTTP endpoints to kepler thus removing the need to support -cpu-profile or -memory-profile explicitly. See also: #1383 Signed-off-by: Sunil Thaha <[email protected]>
verified by running
go tool pprof http://localhost:8888/debug/pprof/heap
.