chore(bpf): Fix Kepler Licensing #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @dave-tucker for the investigation and the PR! @marceloamaral @sunya-ch @jiangphcn @jiangphcn please take a look and let us know if you are good with the transition. Thanks! |
sunya-ch
reviewed
Apr 27, 2024
There was a problem hiding this comment.
@dave-tucker Thank you for the PR. This transition looks good to me.
|
thanks, this is good update~ |
|
@marceloamaral @jiangphcn can you take a look? |
jiangphcn
reviewed
Apr 29, 2024
|
LGTM. |
The eBPF code needs to have a GPL-compatible license. This is due to its use of Linux Kernel structs (like task_struct) and its use of GPL-only eBPF helpers (e.g bpf_probe_read) [1]. eBPF loaders default to GPL when loading code without a license section. You can verify this by inspecting the loaded probes with bpftool. This commit adjusts the license of the eBPF files to be: - GPL-2.0-only OR BSD-2-Clause for Kepler code - GPL-2.0-only for the generated vmlinux.h files given they come from the Linux Kernel. It adjusts the README to display these changes. [1]: https://github.com/torvalds/linux/blob/c942a0cd3603e34dd2d7237e064d9318cb7f9654/kernel/trace/bpf_trace.c#L243-L250 Signed-off-by: Dave Tucker <[email protected]>
dave-tucker
force-pushed
the
bpf-license
branch
from
209f304 to
d5d1380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eBPF code needs to have a GPL-compatible license. This is due to its use of Linux Kernel structs (like task_struct) and its use of GPL-only eBPF helpers (e.g bpf_probe_read) 1.
eBPF loaders default to GPL when loading code without a license section, which is why this might not have prevented the probes from working correctly. You can verify this by inspecting the loaded probes with bpftool.
This commit adjusts the license of the eBPF files to be:
It adjusts the README to display these changes.
The following contributors will need to agree to the relicensing of this work according to the git history.
This licensing arrangement is established in mature eBPF projects like Cilium.
Userspace components are unaffected.
There is a license exception in the CNCF to allow it.