Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bpf): Incorrect map size for processes and pid_time #1410

Closed
wants to merge 1 commit into from

Conversation

dave-tucker
Copy link
Collaborator

Reported by @vimalk78 - Thanks 🙏

@sthaha
Copy link
Collaborator

sthaha commented May 8, 2024

@dave-tucker , could you please shed some light into what this fixes? I understand the earlier code had a larger buffer but
I was thinking more in terms of missing tests. Some test should have flagged the regression which we are missing and probably an opportunity to add it.

@dave-tucker
Copy link
Collaborator Author

dave-tucker commented May 8, 2024

@sthaha I'd gladly add tests but unfortunately doing so is non-trivial given there is no test rigging for ebpf tests in the project (yet). I'll open an issue to add them as well as highlighting any decisions we'll want to make up-front about how to handle that type of testing.
Without a larger buffer we're limited to capturing data for $number_of_cpu_core processes, which could be very low (single digits) 😱

Created issue to track testing: #1412

@dave-tucker
Copy link
Collaborator Author

Closing this PR. Will cherry-pick this commit into #1407 as it's needed to make CI green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants