Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): Use correct variable in IsNodeComponentPowerModelEnabled() #1458

Merged
merged 1 commit into from
May 21, 2024

Conversation

vimalk78
Copy link
Collaborator

@vimalk78 vimalk78 commented May 21, 2024

Use NodeComponentPowerModel instead of NodePlatformPowerModel

This fixes #1459

Copy link
Contributor

github-actions bot commented May 21, 2024

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: This pull request fixes the IsNodeComponentPowerModelEnabled() function by replacing NodePlatformPowerModel with NodeComponentPowerModel, ensuring the correct variable is used to check if the estimator model is enabled. The change is limited to this function within the model package and has no impact on exported functions, global data structures, or the external interface.

Key Modifications:

  • Replaced NodePlatformPowerModel with NodeComponentPowerModel in IsNodeComponentPowerModelEnabled() function.

Impact: The change ensures the correct variable is used for checking the estimator model's enabled status, improving the function's accuracy.

Observations/Suggestions: The change is a minor but important fix, and it's good to see that the function signature remains unchanged. However, it would be beneficial to include a unit test to verify the corrected behavior of the IsNodeComponentPowerModelEnabled() function.

@vimalk78
Copy link
Collaborator Author

Cc: @rootfs @marceloamaral

@vimalk78
Copy link
Collaborator Author

🤖 SeineSailor

Here is a concise summary of the pull request changes:

nice summary !!

@rootfs rootfs merged commit 49acca9 into sustainable-computing-io:main May 21, 2024
25 checks passed
vprashar2929 pushed a commit to openshift-power-monitoring/kepler that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kepler crashes if local regression model cannot be found
2 participants