Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vm name option to validator #1474

Merged
merged 2 commits into from
May 28, 2024
Merged

add vm name option to validator #1474

merged 2 commits into from
May 28, 2024

Conversation

rootfs
Copy link
Contributor

@rootfs rootfs commented May 28, 2024

Adding vm name option allows this CI pipeline to use this option to automate the validation test

@rootfs rootfs requested review from KaiyiLiu1234 and sthaha May 28, 2024 19:17
Copy link
Contributor

github-actions bot commented May 28, 2024

🤖 SeineSailor

Here's a concise summary of the pull request changes:

Summary: This pull request introduces a vm_name option to the Validator, enabling more flexible querying and validation for processes or VMs based on their names. Key modifications include:

  1. Updates to TestCaseResult and TestCase classes to use a formatted level string and query string instead of vm_pid.
  2. Addition of a name field to the VM class, retrieved from the vm_config dictionary.
  3. Introduction of a name field for VM configuration in the metal/vm section of validator.yaml.sample.

Impact: These changes may affect the external behavior of the code, particularly in querying and filtering data based on VM ID or name. The addition of the name field promotes flexibility in managing VM resources and improves readability in configuration files.

Observations/Suggestions:

  • It would be beneficial to update the documentation to reflect the new vm_name option and its usage.
  • Consider adding tests to ensure the vm_name option works as expected, especially when querying and filtering data.
  • The name field in validator.yaml.sample could be made optional to accommodate existing configurations.

Overall, these changes enhance the flexibility and readability of the Validator and its configuration options.

Copy link
Collaborator

@KaiyiLiu1234 KaiyiLiu1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rootfs rootfs merged commit 468ed25 into main May 28, 2024
22 checks passed
@rootfs
Copy link
Contributor Author

rootfs commented May 28, 2024

thanks @KaiyiLiu1234! Let's add the validation to the CI next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants