Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: update the verbosity of anoying key error message #1480

Merged
merged 1 commit into from
May 30, 2024

Conversation

marceloamaral
Copy link
Collaborator

update the verbosity of annoying key error message due to missing gpu metrics

@marceloamaral marceloamaral requested a review from sunya-ch May 30, 2024 11:15
Copy link
Contributor

github-actions bot commented May 30, 2024

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: This PR reduces log noise by decreasing the verbosity of an error message related to missing GPU metrics in the stats module from level 5 to 10.

Key Modifications:

  • Updated the default section of the switch case for handling unknown node features in stats.go.
  • Replaced klog.V(5).Infof with klog.V(10).Infof to log the message at a lower frequency.

Impact: This change reduces the visibility of the error message, resulting in less noise for developers. It does not affect the external interface or behavior of the code.

Observations/Suggestions: The change is localized and does not introduce any breaking changes. However, it would be beneficial to include a brief explanation in the commit message or PR description about the motivation behind reducing the verbosity level, making it easier for reviewers to understand the context.

@rootfs rootfs merged commit 8bb405f into sustainable-computing-io:main May 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants