Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSE and MAPE Single Queries #1522

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

KaiyiLiu1234
Copy link
Collaborator

Fixed MSE Queries and added MAPE Queries and included Query outputs in cli. These changes are fixed to @rootfs PR

Fixed MSE Queries and added MAPE Queries.
Included Query outputs in cli.

Signed-off-by: Kaiyi <[email protected]>
@KaiyiLiu1234 KaiyiLiu1234 requested a review from rootfs June 12, 2024 14:46
Copy link
Contributor

github-actions bot commented Jun 12, 2024

🤖 SeineSailor

Here's a concise summary of the pull request changes:

Summary: This pull request, "Fix MSE and MAPE Single Queries," enhances the validator tool to support Mean Absolute Percentage Error (MAPE) queries. Key modifications include:

  • Adding mape_test_cases to CasesResult and mape_prom_queries to KeplerProm classes.
  • Updating the load_test_cases method and stress function to handle MAPE queries.
  • Displaying MAPE query results in the CLI and report.

Impact: These changes improve the validator tool's functionality, allowing it to process MAPE queries and provide relevant output. The modifications are based on a referenced pull request (#1508), ensuring consistency and coherence in the codebase.

Observations/Suggestions:

  • The changes seem well-structured and focused on a specific feature enhancement.
  • It would be beneficial to include unit tests to ensure the new functionality works as expected.
  • Consider adding documentation updates to reflect the changes and provide guidance for users.
  • Review the code for any potential performance implications, especially when handling MAPE queries.

@KaiyiLiu1234
Copy link
Collaborator Author

Note queries that do not work are anyones which are {job='vm', mode='idle'}. VM does not appear to account for idle. Only dynamic.

@rootfs
Copy link
Contributor

rootfs commented Jun 12, 2024

Note queries that do not work are anyones which are {job='vm', mode='idle'}. VM does not appear to account for idle. Only dynamic.

you need to turn on idle power on the VM (i.e. EXPOSE_ESTIMATED_IDLE_POWER_METRICS=true)
https://github.com/sustainable-computing-io/kepler-metal-ci/blob/main/ansible/kepler_playbook.yml#L26

@rootfs rootfs merged commit 9114e75 into sustainable-computing-io:main Jun 12, 2024
24 checks passed
@KaiyiLiu1234 KaiyiLiu1234 deleted the update-queries branch June 27, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants