-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tgid map #1554
Remove tgid map #1554
Conversation
🤖 SeineSailor Here is a concise summary of the pull request changes: Summary: The pull request "Remove tgid map" removes the Key Modifications:
Impact: The external interface remains unaffected, with no changes to exported function signatures, global data structures, or variables. Observations: The removal of the Suggestions for Improvement: Consider adding tests to validate the correctness of the new task structure and tgid acquisition. Additionally, review the codebase for any potential dependencies on the removed |
f218382
to
0991ed5
Compare
bpfassets/libbpf/src/kepler.bpf.c
Outdated
@@ -231,6 +220,7 @@ int kepler_sched_switch_trace(u64 *ctx) | |||
|
|||
prev_pid = (u32)prev_task->pid; | |||
next_pid = (u32)next_task->pid; | |||
prev_tgid = next_task->tgid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be prev_task->tgid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap, fixed!
Signed-off-by: marceloamaral <[email protected]>
0991ed5
to
365ac03
Compare
Per 07/02 meeting, this PR is scheduled for 0.7.11 release. |
With the new task structure in the tracepoint in the code, we can now directly get the previous running task tgid, so that we can remove the map to track and translate the pid to tgid.