feat(validator): Add workflow for validator tests #1570
Conversation
|
🤖 SeineSailor Here is a concise summary of the pull request changes: This pull request introduces a new workflow for running validator tests in the CI pipeline, adding two new make targets ( Observation: The changes are well-contained within the Makefiles and do not introduce any external dependencies or breaking changes. The addition of the Suggestion for improvement: Consider adding a brief description or comment in the Makefile to explain the purpose and usage of the new targets, making it easier for developers to understand and utilize the new workflow. |
vprashar2929
force-pushed
the
add-val-worflow
branch
from
5a92ed6 to
3435bfa
Compare
vprashar2929
changed the title
Makefile
Outdated
| @echo "Running validator tests..." | ||
| @cd ./e2e/tools/validator && \ | ||
| hatch env create && \ | ||
| hatch run test || { echo 'validator-test failed'; exit 1; } |
There was a problem hiding this comment.
| hatch run test || { echo 'validator-test failed'; exit 1; } | |
| hatch run test |
.github/workflows/validator_test.yml
Outdated
| - name: Set up Python | ||
| uses: actions/[email protected] | ||
| with: | ||
| python-version: "3.12" |
There was a problem hiding this comment.
| python-version: "3.12" | |
| python-version: "3.11" |
There was a problem hiding this comment.
Do we have any hard requirements on 3.11 ?
There was a problem hiding this comment.
I have pinned the python version in #1573
Makefile
Outdated
| validator-test: ## Run validator tests. | ||
| @echo "Running validator tests..." | ||
| @cd ./e2e/tools/validator && \ | ||
| hatch env create && \ |
There was a problem hiding this comment.
I think it is better to have a validator-env target that test depends on
There was a problem hiding this comment.
@vprashar2929 , gentle reminder for a separate makefile for Validator :) but actually think hatch makes it really unnecessary to have a Makefile
|
This is great to add to the github actions workflow. The unit tests however need some more work last time I checked. Maybe we can improve it? @vprashar2929 I can raise it as an issue and hop on that if you would like. |
Makefile
Outdated
| validator-test: ## Run validator tests. | ||
| @echo "Running validator tests..." | ||
| @cd ./e2e/tools/validator && \ | ||
| hatch env create && \ |
There was a problem hiding this comment.
@vprashar2929 , gentle reminder for a separate makefile for Validator :) but actually think hatch makes it really unnecessary to have a Makefile
vprashar2929
force-pushed
the
add-val-worflow
branch
3 times, most recently
from
0d21c46 to
cc2d6aa
Compare
vprashar2929
changed the title
This PR introduces a workflow to execute validator tests on CI Additionally, it includes a Makefile within `e2e/tools/validator` enabling the execution of targets such as `make fmt` and `make test` for local testing Signed-off-by: Vibhu Prashar <[email protected]>
vprashar2929
force-pushed
the
add-val-worflow
branch
from
cc2d6aa to
3b171a4
Compare
This PR introduces a workflow to execute validator tests on CI Additionally, it includes a Makefile within
e2e/tools/validator, enabling the execution of targets such asmake fmtandmake testfor local testing